-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset the keyboard to default state during initialization #632
Reset the keyboard to default state during initialization #632
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #632 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21561 21561
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19028 19028
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this to address the issue where LED state is not synchronized at init. There are a couple of other issues in existing code that need to be addressed (e.g. set_key_toggle_state
is not actually updating state to endpoint), but I will work on those as part of a separate PR to refactor LED handling a bit.
@joschock, can you please file a bug in the repo to track those? |
## Description Fixes #633 Reset the keyboard to default state during initialization in order to make sure the LED status on keyboard is determined. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned off when booting to the UEFI front page. No regressions observed. ## Integration Instructions N/A
Description
Fixes #633
Reset the keyboard to default state during initialization in order to make sure the LED status on keyboard is determined.
How This Was Tested
Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned off when booting to the UEFI front page.
No regressions observed.
Integration Instructions
N/A