Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the keyboard to default state during initialization #632

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

wenbhou
Copy link
Contributor

@wenbhou wenbhou commented Feb 18, 2025

Description

Fixes #633

Reset the keyboard to default state during initialization in order to make sure the LED status on keyboard is determined.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned off when booting to the UEFI front page.
No regressions observed.

Integration Instructions

N/A

@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Feb 18, 2025
@apop5 apop5 requested a review from makubacki February 18, 2025 15:15
@makubacki makubacki added the type:bug Something isn't working label Feb 18, 2025
@makubacki
Copy link
Member

@joschock

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.59%. Comparing base (7d24bdc) to head (4d1ea91).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #632   +/-   ##
===========================================
  Coverage       11.59%   11.59%           
===========================================
  Files             132      132           
  Lines           21561    21561           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19028    19028           
  Partials           34       34           
Flag Coverage Δ
HidPkg 2.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joschock joschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this to address the issue where LED state is not synchronized at init. There are a couple of other issues in existing code that need to be addressed (e.g. set_key_toggle_state is not actually updating state to endpoint), but I will work on those as part of a separate PR to refactor LED handling a bit.

@makubacki
Copy link
Member

Approving this to address the issue where LED state is not synchronized at init. There are a couple of other issues in existing code that need to be addressed (e.g. set_key_toggle_state is not actually updating state to endpoint), but I will work on those as part of a separate PR to refactor LED handling a bit.

@joschock, can you please file a bug in the repo to track those?

@makubacki makubacki merged commit f55d046 into microsoft:dev/202405 Feb 18, 2025
28 checks passed
ProjectMuBot pushed a commit that referenced this pull request Feb 18, 2025
## Description

Fixes #633

Reset the keyboard to default state during initialization in order to
make sure the LED status on keyboard is determined.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Tested on Surface Laptop and Surface Pro, all keyboard LEDs are turned
off when booting to the UEFI front page.
No regressions observed.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:backport Backport changes in a dev branch PR to its release branch. type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Keyboard Caps Lock LED status is incorrect after rebooting to UEFI with Caps Lock LED ON
5 participants