-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MmSupervisorPkg: Add MmSupervisorRing3Performance #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81fab76
to
763154a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
========================================
- Coverage 0.50% 0.50% -0.01%
========================================
Files 142 143 +1
Lines 20604 20613 +9
Branches 60 60
========================================
Hits 105 105
- Misses 20494 20503 +9
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
reviewed
Feb 4, 2025
apop5
reviewed
Feb 4, 2025
apop5
approved these changes
Feb 4, 2025
kuqin12
approved these changes
Feb 10, 2025
Adds a new `MM_STANDALONE` driver that is used to link against a `PerformanceLib` core instance for MM user mode drivers. An empty driver is reserved for this use case for the following reasons: 1. Make integration and debug obvious and easy by having a clearly named and designated driver for this purpose. 2. To be among the first MM user mode drivers dispatched to install the performance protocol and make the performance service available to other user mode drivers as early as possible. 3. To avoid linking directly to `MmSupervisorRing3Broker`. The MM Core performance library instance code has functionality that depends on MM services to be available. Since the Ring 3 Broker is reponsible for initializing MM services in user mode, it is complicated and error prone to attempt to defer using those services to install the performance protocol until syscall has been set up with the core and a proper `gMmst` global could be used by the common MM code. This is all much simpler and easier to integrate in a separate MM user mode driver. 4. To avoid linking the library to a pre-existing MM module that may have an unknown number of depdencies in its DEPEX. Since the DEPEX on a given platform aggregates all of the dependencies in linked libraries, it is not safe to assume any given MM module not dedicated exclusively for this purpose will not have unrelated dependencies that unnecessarily prolong installation of the performance protocol. Signed-off-by: Michael Kubacki <[email protected]>
763154a
to
3289d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type:documentation
Improvements or additions to documentation
type:feature-request
A new feature proposal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #383
Adds a new
MM_STANDALONE
driver that is used to link against aPerformanceLib
core instance for MM user mode drivers.An empty driver is reserved for this use case for the following
reasons:
named and designated driver for this purpose.
the performance protocol and make the performance service
available to other user mode drivers as early as possible.
MmSupervisorRing3Broker
. The MMCore performance library instance code has functionality that
depends on MM services to be available. Since the Ring 3 Broker
is reponsible for initializing MM services in user mode, it is
complicated and error prone to attempt to defer using those
services to install the performance protocol until syscall has
been set up with the core and a proper
gMmst
global could beused by the common MM code. This is all much simpler and easier
to integrate in a separate MM user mode driver.
may have an unknown number of depdencies in its DEPEX. Since
the DEPEX on a given platform aggregates all of the dependencies
in linked libraries, it is not safe to assume any given MM module
not dedicated exclusively for this purpose will not have unrelated
dependencies that unnecessarily prolong installation of the
performance protocol.
Temporarily includes this commit:
TEMP - .pytool/CISettings.py: Use Mu Basecore Standalone MM Perf Branch
Temporarily use this branch for testing.
This commit will be reverted after the following Mu Basecore PR is
merged:
microsoft/mu_basecore#1268
How This Was Tested
MmSupervisorRing3Performance
to retrieve MM performance recordswith the MM Supervisor on Q35.
Integration Instructions