[Cherry-Pick] Fix naming convention in FirmwareVolume2 gmock #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crosoft#1166) ## Description Fix naming convention for FirmwareVolume2 gmock. - Rename `FV_ReadFile` -> `FvReadFile` - Rename `FV_WriteFile` -> `FvWriteFile` ---- - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Unit tests component can call these mock functions success ## Integration Instructions N/A --------- Signed-off-by: TsunFeng <[email protected]>
github-actions
bot
added
the
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1207 +/- ##
===============================================
Coverage 1.59% 1.59%
===============================================
Files 1449 1449
Lines 362723 362723
Branches 5632 5632
===============================================
Hits 5776 5776
Misses 356840 356840
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix naming convention for FirmwareVolume2 gmock.
FV_ReadFile->FvReadFileFV_WriteFile->FvWriteFilecherry-pick of
How This Was Tested
Unit tests component can call these mock functions success
Integration Instructions
N/A