Skip to content

Commit

Permalink
BaseTools: Remove /NXCOMPAT VS X64 DLINK flags (#468)
Browse files Browse the repository at this point in the history
## Description

/NXCOMPAT and /SUBSYSTEM:CONSOLE flags were added to enable setting the
nxcompat bit in the DLL characteristics. GenFw will now set the nxcompat
bit in the DLL characteristics if the requirements to be nxcompat are
met.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Ran CI and all QemuQ35 EFI_APPLICATION tests for VS2022 DEBUG/RELEASE
builds.

## Integration Instructions

N/A
  • Loading branch information
Javagedes authored Jun 26, 2023
1 parent 595e2e3 commit 1077173
Showing 1 changed file with 39 additions and 39 deletions.
Loading

0 comments on commit 1077173

Please sign in to comment.