microsoft · TalZaccai · Mar 8, 2025 · Mar 7, 2025 · Mar 7, 2025 · Mar 7, 2025
diff --git a/.editorconfig b/.editorconfig
@@ -43,6 +43,9 @@ dotnet_diagnostic.CA1866.severity = warning
 dotnet_diagnostic.CA1867.severity = warning
 
 # Usage rules
+# Treat unnecessary usings as warnings
+dotnet_diagnostic.IDE0005.severity = warning
+
 # CA2254: Template should be a static expression
 dotnet_diagnostic.CA2254.severity = warning
 

diff --git a/benchmark/BDN.benchmark/Embedded/EmbeddedNetworkHandler.cs b/benchmark/BDN.benchmark/Embedded/EmbeddedNetworkHandler.cs
@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Diagnostics;
-using System.Threading.Tasks;
 using Garnet.common;
 using Garnet.networking;
 using Microsoft.Extensions.Logging;

diff --git a/benchmark/BDN.benchmark/Embedded/EmbeddedRespServer.cs b/benchmark/BDN.benchmark/Embedded/EmbeddedRespServer.cs
@@ -2,10 +2,8 @@
 // Licensed under the MIT license.
 
 using Garnet;
-using Garnet.common;
 using Garnet.server;
 using Microsoft.Extensions.Logging;
-using Tsavorite.core;
 
 namespace Embedded.server
 {

diff --git a/benchmark/BDN.benchmark/Embedded/GarnetServerEmbedded.cs b/benchmark/BDN.benchmark/Embedded/GarnetServerEmbedded.cs
@@ -1,10 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Net;
 using System.Net.Security;
-using System.Threading;
 using Garnet.common;
 using Garnet.networking;
 using Garnet.server;

diff --git a/benchmark/Resp.benchmark/RespOnlineBench.cs b/benchmark/Resp.benchmark/RespOnlineBench.cs
@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Buffers;
 using System.Diagnostics;
 using System.Linq;
 using System.Net;

diff --git a/libs/common/Logging/FileLoggerProvider.cs b/libs/common/Logging/FileLoggerProvider.cs
@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Text;
 using Microsoft.Extensions.Logging;

diff --git a/libs/host/Configuration/Redis/RedisTypes.cs b/libs/host/Configuration/Redis/RedisTypes.cs
@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 using System.ComponentModel;
-using Garnet.server.Auth.Settings;
 
 namespace Garnet
 {

diff --git a/libs/server/ACL/CommandPermissionSet.cs b/libs/server/ACL/CommandPermissionSet.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Diagnostics;
-using System.Linq;
 using System.Runtime.CompilerServices;
 
 namespace Garnet.server.ACL

diff --git a/libs/server/Auth/Aad/IssuerSigningTokenProvider.cs b/libs/server/Auth/Aad/IssuerSigningTokenProvider.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading;
 using Microsoft.Extensions.Logging;
 using Microsoft.IdentityModel.Protocols;

diff --git a/libs/server/Auth/GarnetAclWithAadAuthenticator.cs b/libs/server/Auth/GarnetAclWithAadAuthenticator.cs
@@ -2,10 +2,6 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Garnet.server.ACL;
 using Microsoft.Extensions.Logging;
 

diff --git a/libs/server/Auth/GarnetAclWithPasswordAuthenticator.cs b/libs/server/Auth/GarnetAclWithPasswordAuthenticator.cs
@@ -2,10 +2,7 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Text;
-using System.Threading.Tasks;
 using Garnet.server.ACL;
 using Microsoft.Extensions.Logging;
 

diff --git a/libs/server/Custom/CustomObjectBase.cs b/libs/server/Custom/CustomObjectBase.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 using System.IO;
-using Tsavorite.core;
 
 namespace Garnet.server
 {

diff --git a/libs/server/Lua/LuaStateWrapper.cs b/libs/server/Lua/LuaStateWrapper.cs
@@ -6,7 +6,6 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Text;
-using System.Threading;
 using Garnet.common;
 using KeraLua;
 using Microsoft.Extensions.Logging;

diff --git a/libs/server/Lua/SessionScriptCache.cs b/libs/server/Lua/SessionScriptCache.cs
@@ -5,7 +5,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Security.Cryptography;
-using System.Threading;
 using Garnet.server.ACL;
 using Garnet.server.Auth;
 using Garnet.server.Lua;

diff --git a/libs/server/Metrics/Latency/RespLatencyCommands.cs b/libs/server/Metrics/Latency/RespLatencyCommands.cs
@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using Garnet.common;
 
 namespace Garnet.server

diff --git a/libs/server/Objects/Hash/HashObjectImpl.cs b/libs/server/Objects/Hash/HashObjectImpl.cs
@@ -6,7 +6,6 @@
 using System.Buffers.Text;
 using System.Diagnostics;
 using System.Globalization;
-using System.Linq;
 using System.Text;
 using Garnet.common;
 using Tsavorite.core;

diff --git a/libs/server/Objects/ItemBroker/CollectionItemBrokerEvent.cs b/libs/server/Objects/ItemBroker/CollectionItemBrokerEvent.cs
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using Tsavorite.core;
-
 namespace Garnet.server
 {
     /// <summary>

diff --git a/libs/server/Objects/Types/GarnetObjectBase.cs b/libs/server/Objects/Types/GarnetObjectBase.cs
@@ -6,7 +6,6 @@
 using System.IO;
 using System.Text;
 using System.Threading;
-using Tsavorite.core;
 
 namespace Garnet.server
 {

diff --git a/libs/server/Objects/Types/IGarnetObject.cs b/libs/server/Objects/Types/IGarnetObject.cs
@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using Tsavorite.core;
 
 namespace Garnet.server
 {

diff --git a/libs/server/Providers/TsavoriteKVProviderBase.cs b/libs/server/Providers/TsavoriteKVProviderBase.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using Garnet.common;
 using Garnet.networking;
 using Tsavorite.core;
 

diff --git a/libs/server/Resp/Parser/SessionParseState.cs b/libs/server/Resp/Parser/SessionParseState.cs
@@ -5,7 +5,6 @@
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using System.Text;
 using Garnet.common;
 using Garnet.common.Parsing;
 using Tsavorite.core;

diff --git a/libs/server/Resp/RespCommandInfoFlags.cs b/libs/server/Resp/RespCommandInfoFlags.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.ComponentModel;
-using System.Net.NetworkInformation;
 
 namespace Garnet.server
 {

diff --git a/libs/server/Servers/MetricsApi.cs b/libs/server/Servers/MetricsApi.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Collections.Generic;
 using Garnet.common;
 

diff --git a/libs/server/Storage/Functions/MainStore/ReadMethods.cs b/libs/server/Storage/Functions/MainStore/ReadMethods.cs
@@ -3,7 +3,6 @@
 
 using System.Buffers;
 using System.Diagnostics;
-using System.Runtime.CompilerServices;
 using Garnet.common;
 using Tsavorite.core;
 

diff --git a/libs/server/Storage/Session/Common/ArrayKeyIterationFunctions.cs b/libs/server/Storage/Session/Common/ArrayKeyIterationFunctions.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Tsavorite.core;
 
 namespace Garnet.server

diff --git a/libs/server/Storage/Session/MainStore/HyperLogLogOps.cs b/libs/server/Storage/Session/MainStore/HyperLogLogOps.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Diagnostics;
-using System.Text;
 using Tsavorite.core;
 
 namespace Garnet.server

diff --git a/libs/storage/Tsavorite/cs/src/core/Index/Recovery/Checkpoint.cs b/libs/storage/Tsavorite/cs/src/core/Index/Recovery/Checkpoint.cs
@@ -2,9 +2,8 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Linq;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;

 namespace Tsavorite.core

diff --git a/libs/storage/Tsavorite/cs/src/core/TsavoriteLog/ILogEntryConsumer.cs b/libs/storage/Tsavorite/cs/src/core/TsavoriteLog/ILogEntryConsumer.cs
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
-
 namespace Tsavorite.core
 {
     /// <summary>

diff --git a/libs/storage/Tsavorite/cs/test/BasicTests.cs b/libs/storage/Tsavorite/cs/test/BasicTests.cs
@@ -6,7 +6,6 @@
 using System.IO;
 using System.Linq;
 using NUnit.Framework;
-using NUnit.Framework.Internal;
 using NUnit.Framework.Legacy;
 using Tsavorite.core;
 using static Tsavorite.test.TestUtils;

diff --git a/libs/storage/Tsavorite/cs/test/DeviceLogTests.cs b/libs/storage/Tsavorite/cs/test/DeviceLogTests.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Buffers;
 using System.IO;
 using System.Linq;

diff --git a/libs/storage/Tsavorite/cs/test/LogScanTests.cs b/libs/storage/Tsavorite/cs/test/LogScanTests.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.IO;
 using System.Threading;
 using NUnit.Framework;

diff --git a/libs/storage/Tsavorite/cs/test/LogShiftTailStressTest.cs b/libs/storage/Tsavorite/cs/test/LogShiftTailStressTest.cs
@@ -5,7 +5,6 @@
 using System.Collections.Generic;
 using System.Threading;
 using NUnit.Framework;
-using NUnit.Framework.Legacy;
 using Tsavorite.core;
 
 namespace Tsavorite.test

diff --git a/libs/storage/Tsavorite/cs/test/ObjectRecoveryTest.cs b/libs/storage/Tsavorite/cs/test/ObjectRecoveryTest.cs
@@ -2,11 +2,9 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Threading.Tasks;
 using NUnit.Framework;
-using NUnit.Framework.Legacy;
 using Tsavorite.core;
 
 namespace Tsavorite.test.recovery.objects

diff --git a/libs/storage/Tsavorite/cs/test/ObjectRecoveryTest2.cs b/libs/storage/Tsavorite/cs/test/ObjectRecoveryTest2.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.IO;
 using System.Threading.Tasks;
 using NUnit.Framework;

diff --git a/libs/storage/Tsavorite/cs/test/ObjectTestTypes.cs b/libs/storage/Tsavorite/cs/test/ObjectTestTypes.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using NUnit.Framework;
 using NUnit.Framework.Legacy;
 using Tsavorite.core;
 

diff --git a/libs/storage/Tsavorite/cs/test/SharedDirectoryTests.cs b/libs/storage/Tsavorite/cs/test/SharedDirectoryTests.cs
@@ -9,7 +9,6 @@
 using System.Threading.Tasks;
 using Microsoft.Win32.SafeHandles;
 using NUnit.Framework;
-using NUnit.Framework.Internal;
 using NUnit.Framework.Legacy;
 using Tsavorite.core;
 

diff --git a/libs/storage/Tsavorite/cs/test/SpanByteTests.cs b/libs/storage/Tsavorite/cs/test/SpanByteTests.cs
@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Runtime.InteropServices;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;

diff --git a/libs/storage/Tsavorite/cs/test/TestTypes.cs b/libs/storage/Tsavorite/cs/test/TestTypes.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Threading;
-using NUnit.Framework;
 using NUnit.Framework.Legacy;
 using Tsavorite.core;
 

diff --git a/libs/storage/Tsavorite/cs/test/TestUtils.cs b/libs/storage/Tsavorite/cs/test/TestUtils.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.IO;
-using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;

diff --git a/libs/storage/Tsavorite/cs/test/VLVector.cs b/libs/storage/Tsavorite/cs/test/VLVector.cs
@@ -3,7 +3,6 @@
 
 using System;
 using System.Runtime.CompilerServices;
-using NUnit.Framework;
 using NUnit.Framework.Legacy;
 using Tsavorite.core;
 

diff --git a/main/GarnetServer/Extensions/DeleteIfMatch.cs b/main/GarnetServer/Extensions/DeleteIfMatch.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Buffers;
 using System.Diagnostics;
 using Garnet.server;

diff --git a/main/GarnetServer/Extensions/GetTwoKeysNoTxn.cs b/main/GarnetServer/Extensions/GetTwoKeysNoTxn.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using Garnet.common;
 using Garnet.server;
 

diff --git a/main/GarnetServer/Extensions/MGetIfPM.cs b/main/GarnetServer/Extensions/MGetIfPM.cs
@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
-using System.Collections.Generic;
 using Garnet.common;
 using Garnet.server;
 

diff --git a/main/GarnetServer/Extensions/MSetPx.cs b/main/GarnetServer/Extensions/MSetPx.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using Garnet.common;
 using Garnet.server;
 

diff --git a/main/GarnetServer/Extensions/MyDictGet.cs b/main/GarnetServer/Extensions/MyDictGet.cs
@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
 using System.Buffers;
 using System.Diagnostics;
 using Garnet.server;

diff --git a/main/GarnetServer/Extensions/MyDictObject.cs b/main/GarnetServer/Extensions/MyDictObject.cs
@@ -1,11 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-using System.IO;
 using Garnet.server;
 using Tsavorite.core;