Fix: Azure Device Behavior for Non-Existent Files #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… draft/priyanjgupta/authSupport
…iyanjgupta-garnet-master
badrishc
reviewed
Mar 7, 2025
libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageDevice.cs
Outdated
Show resolved
Hide resolved
…/github.com/priyanjgupta/garnet into usr/priyanjgupta/azureDeviceBlobNotFoundFix
badrishc
approved these changes
Mar 7, 2025
TalZaccai
reviewed
Mar 7, 2025
| TryReadAsync(blobEntry, (long)sourceAddress, (long)destinationAddress, readLength, id); | ||
| } | ||
|
|
||
| void TryReadAsync(BlobEntry blobEntry, long sourceAddress, long destinationAddress, uint readLength, long id) |
There was a problem hiding this comment.
naming: This is not an async method (same goes for ReadFromBlobAsync)
There was a problem hiding this comment.
The convention in AzureStorageDevice currently is that methods that perform work asynchronously end in Async, even if they are not strictly within the async-await paradigm. So I would leave it as is for this PR.
| { | ||
| // If pageBlob is null, it means the blob has not been created yet. We should wait for it to be created. | ||
| if (blobEntry.PageBlob.Default == null | ||
| && blobEntry.TryQueueAction(() => ReadFromBlobAsync(blobEntry, sourceAddress, destinationAddress, readLength, id))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
The current recovery logic uses a double buffering scan for commits, causing the page the device is searching for to spill into the next segment, which may not exist. In such cases, the device repeatedly retries to find the non-existent file, resulting in a 90-second hang and eventually a "blob not found" error. This causes all subsequent read/write requests to be canceled under the current implementation. In contrast, the local device creates the file when it encounters a non-existent file. This PR aims to align the behavior between both device implementations.
Steps to reproduce the bug:
Start garnet server with following flags
After the blob not found error, subsequent writes should fail to commit.
Screenshots
Expected Behavior
