-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the Tsavorite checkpoint state machine #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove deprecated white box test
TedHartMS
reviewed
Mar 4, 2025
libs/storage/Tsavorite/cs/src/core/ClientSession/ManageClientSessions.cs
Outdated
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/TsavoriteThread.cs
Outdated
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/Index/Checkpointing/StateMachineDriver.cs
Outdated
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/Index/Checkpointing/StateMachineDriver.cs
Show resolved
Hide resolved
libs/storage/Tsavorite/cs/src/core/Index/Checkpointing/TsavoriteStateMachine.cs
Outdated
Show resolved
Hide resolved
…whether to spin or operate in PREPARE phase. Moved isAcquiredLockable to Ctx. This commit also removes a race that will re-establish the invariant that no threads are operating in PREPARE while any thread is operating in IN_PROGRESS phase.
TedHartMS
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateMachineDriver.RunStateMachine
) to drive the state machine instead of letting user threads cooperatively run it. This can also reduce tail latency of unlucky user operations that need to drive the state machine.prepare
andin_progress
phases at once. The "checkpoint version switch barrer" option is consequently removed as well. This removes theCPR_SHIFT_DETECTED
andLatchDestination.Retry
code paths.OnThreadState
component. We also eliminate theThreadStateMachine
step of individual threads. This aspect of checkpointing was complex and errorprone.Mark
andCheckIsComplete
as a result of the thread-level simplifications mentioned above.(v) -> (v+1)
switch across the string and object stores in Garnet.(v)
transactions have to end inprepare
, before(v+1)
transactions can start inin_progress
. However, this PR simplifies the future optimization of allowing(v+1)
transactions to start as soon as(v)
transactions have acquired all their locks. This will significantly reduce the overhead of the barrier during the checkpoint.SimpleVersionSchemeTest
andSimulatedFlakyDevice