Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining GEOSEARCH functionality. #1058

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

prvyk
Copy link
Contributor

@prvyk prvyk commented Feb 28, 2025

Implement GEOSEARCH BYRADIUS.
Implement also ASC, DESC orderings, ANY, WITHHASH and FROMLATLONG.
Implement GEORADIUS_RO and GEORADIUSBYMEMBER_RO.
Implement GEORADIUS and GEORADIUSBYMEMBER.
Fix GEOSEARCHSTORE without STOREDIST.
Add tests.

@prvyk prvyk force-pushed the georadiusro branch 2 times, most recently from b2c5ceb to c1e3087 Compare March 3, 2025 19:26
@TalZaccai TalZaccai self-requested a review March 4, 2025 19:14
@prvyk prvyk changed the title Implement more of GEOSEARCH functionality. Implement remaining GEOSEARCH functionality. Mar 4, 2025
prvyk added 10 commits March 8, 2025 03:29
Implement GEORADIUS_RO and GEORADIUSBYMEMBER_RO.
Implement most of GEORADIUS and GEORADIUSBYMEMBER.
Add tests.
It's more intutative to check STORE instead of READONLY when the command enum is called GEOSEARCH.
Fix default GEOSEARCHSTORE which apparently never worked since hash wasn't used as score.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant