add comment

microsoft · Mar 8, 2025 · af870fb · af870fb
1 parent bbad4f0
commit af870fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/libs/storage/Tsavorite/cs/src/core/Index/Checkpointing/StreamingSnapshotCheckpointSMTask.cs b/libs/storage/Tsavorite/cs/src/core/Index/Checkpointing/StreamingSnapshotCheckpointSMTask.cs
@@ -35,7 +35,6 @@ public override void GlobalBeforeEnteringState(SystemState next, StateMachineDri
                     store._lastSnapshotCheckpoint.Dispose();
                     store._hybridLogCheckpointToken = guid;
                     store.InitializeHybridLogCheckpoint(store._hybridLogCheckpointToken, next.Version);
-                    store._hybridLogCheckpoint.info.version = next.Version;
                     store._hybridLogCheckpoint.info.nextVersion = targetVersion == -1 ? next.Version + 1 : targetVersion;
                     store.StreamingSnapshotScanPhase1();
                     break;

diff --git a/test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs b/test/Garnet.test.cluster/ReplicationTests/ClusterReplicationDisklessSyncTests.cs
@@ -237,6 +237,8 @@ public void ClusterDBVersionAlignmentDisklessSync([Values] bool disableObjects,
             var primaryVersion = context.clusterTestUtils.GetStoreCurrentVersion(primaryIndex, isMainStore: true, logger: context.logger);
             var replicaOneVersion = context.clusterTestUtils.GetStoreCurrentVersion(replicaOneIndex, isMainStore: true, logger: context.logger);
 
+            // With unified store, versions increase per scan (main and object)
+            // so expected versions depend on whether objects are disabled or not
             var expectedVersion1 = disableObjects ? 2 : 3;
             ClassicAssert.AreEqual(expectedVersion1, primaryVersion);
             ClassicAssert.AreEqual(primaryVersion, replicaOneVersion);
@@ -260,6 +262,9 @@ public void ClusterDBVersionAlignmentDisklessSync([Values] bool disableObjects,
             primaryVersion = context.clusterTestUtils.GetStoreCurrentVersion(primaryIndex, isMainStore: true, logger: context.logger);
             replicaOneVersion = context.clusterTestUtils.GetStoreCurrentVersion(replicaOneIndex, isMainStore: true, logger: context.logger);
             var replicaTwoVersion = context.clusterTestUtils.GetStoreCurrentVersion(replicaTwoIndex, isMainStore: true, logger: context.logger);
+
+            // With unified store, versions increase per scan (main and object)
+            // so expected versions depend on whether objects are disabled or not
             var expectedVersion2 = disableObjects ? 3 : 5;
             ClassicAssert.AreEqual(expectedVersion2, primaryVersion);
             ClassicAssert.AreEqual(primaryVersion, replicaTwoVersion);
@@ -274,6 +279,9 @@ public void ClusterDBVersionAlignmentDisklessSync([Values] bool disableObjects,
             primaryVersion = context.clusterTestUtils.GetStoreCurrentVersion(primaryIndex, isMainStore: true, logger: context.logger);
             replicaOneVersion = context.clusterTestUtils.GetStoreCurrentVersion(replicaOneIndex, isMainStore: true, logger: context.logger);
             replicaTwoVersion = context.clusterTestUtils.GetStoreCurrentVersion(replicaTwoIndex, isMainStore: true, logger: context.logger);
+
+            // With unified store, versions increase per scan (main and object)
+            // so expected versions depend on whether objects are disabled or not
             var expectedVersion3 = disableObjects ? 4 : 7;
             ClassicAssert.AreEqual(expectedVersion3, primaryVersion);
             ClassicAssert.AreEqual(primaryVersion, replicaOneVersion);