Gracefully terminating TCP connections during server.Dispose (#1051)

* Update RespReadResponseUtils.cs

* Update RespReadResponseUtils.cs

* Update RespReadResponseUtils.cs

* dotnet formatted

* added length check with null check

* Added UT to validate no exceptions

* Keeping async pattern for test similar to other tests.

* When a k8s pod hosting garnet service is gracefully shutting down, socket.Dispose() terminates the tcp with a RST packet which is forced termination of the tcp connection. This causes the client to keep connecting with SYN packets with stale IP resulting in SYN flooding from SERedis client.
Using socket.Shutdown() and socket.Close() to send a FIN closes the socket connection gracefully. SERedis client handles FIN by having exponential backoff retries.
Updated version

---------

Co-authored-by: Tejas Kulkarni <[email protected]>
Co-authored-by: Vasileios Zois <[email protected]>

Version.props

@@ -1,6 +1,6 @@
 <Project>
 	<!-- VersionPrefix property for builds and packages -->
 	<PropertyGroup>
-		<VersionPrefix>1.0.57</VersionPrefix>
+		<VersionPrefix>1.0.58</VersionPrefix>
 	</PropertyGroup>
 </Project>

libs/common/Networking/TcpNetworkHandlerBase.cs

@@ -140,7 +140,25 @@ void Start(bool useTLS)
         /// <inheritdoc />
         public override void Dispose()
         {
-            socket.Dispose();
+            try
+            {
+                if (socket.Connected)
+                {
+                    // Gracefully shutdown the socket connection
+                    socket.Shutdown(SocketShutdown.Both);
+                }
+            }
+            catch (Exception ex)
+            {
+                logger?.LogError(ex, "Error shutting down socket");
+            }
+            finally
+            {
+                // Always close the socket to release the resources
+                socket.Close();
+                // Dispose of the socket to free up unmanaged resources
+                socket.Dispose();
+            }
         }
 
         void Dispose(SocketAsyncEventArgs e)