Add Authentication & Logging #11
Merged
+785
−430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobKnightley
changed the base branch from
users/JacobKnightley/update_format
to
main
JacobKnightley
force-pushed
the
users/JacobKnightley/authentication_logging
branch
from
9cd65ce to
8c86edf
Compare
JacobKnightley
changed the base branch from
main
to
users/JacobKnightley/identify_auth_type
JacobKnightley
changed the base branch from
users/JacobKnightley/identify_auth_type
to
main
added 22 commits
January 6, 2025 09:27
…/github.com/microsoft/fabric-cicd into users/JacobKnightley/authentication_logging
JacobKnightley
commented
Jan 6, 2025
|
|
||
|
|
||
| class FabricEndpoint: | ||
| """ | ||
| Handles interactions with the Fabric API, including authentication and request management. | ||
| """ | ||
|
|
||
| def __init__(self, debug_output=False): | ||
| def __init__(self, token_credential=None): |
There was a problem hiding this comment.
Should not be optional
sample/optional_parameters.py
Outdated
| token_credential = TokenCredential | ||
|
|
||
| # Optional: Print all API calls to log file | ||
| change_log_level() |
There was a problem hiding this comment.
Invalid, needs "DEBUG" in call
Fixed all suggested changes. |
shirasassoon
reviewed
Jan 7, 2025
shirasassoon
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the project, focusing on configuration improvements, dependency management, and adding sample scripts for various authentication methods. The most important changes are grouped by theme below:
Configuration Improvements:
.vscode/settings.json: Enablededitor.formatOnSavefor all files and specifically for PowerShell files, and removed redundanteditor.formatOnSavesetting from theruffsection. [1] [2]Dependency Management:
pyproject.toml: Changed to dynamically load version and dependencies fromVERSIONandrequirements.txtfiles, respectively. [1] [2]requirements-dev.txt: Addedruff,gitpython,build, andtwineas development dependencies.Version Update:
VERSION: Updated the version to0.1.6.Sample Scripts:
sample/auth_default_credential.py: Example leveraging default authentication flows.sample/auth_spn_secret.py: Example of authenticating with SPN + Secret.sample/optional_parameters.py: Example of optional parameters forFabricWorkspaceand publish functions.sample/set_vars_from_ado_build.py: Example to set variables based on the target environment using ADO build.sample/set_vars_from_git_branch.py: Example to set variables based on the current Git branch name.Code Enhancements:
src/fabric_cicd/__init__.py: Added achange_log_levelfunction to configure logging levels and included logging setup in the module initialization.src/fabric_cicd/_common/_exceptions.py: Introduced custom exception classes for better error handling.