Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Tasks on MacOS agents not completing but marked as succeeded. #5092

Merged
merged 59 commits into from
Jan 16, 2025

Conversation

sahilbhattMS
Copy link
Contributor

Description:
Some pipelines using MacOS agents reported tasks not completing but still being marked as succeeded. Disabling resource utilization warnings seemed to mitigate this issue.

An analysis of various debug logs indicated that the problem was due to the resource utilization warnings' implementation in MacOS, where multiple CPU and memory info processes were being invoked simultaneously.

Changes made:

  1. Locks added to ensure that there are no simultaneous calls to CPU and memory info processes.
  2. Dispose standard output/error streams. Refer: Process class leaks pipes on MacOS when redirecting stdout and stderr dotnet/runtime#58872

Validations done:
The issue did not reproduce on running a test pipeline on a self-hosted MacOS agent using the above-mentioned changes.

Note: This is the same as the closed PR: #5079. Re-opened as a new PR due to some issues during CI checks.

@sahilbhattMS sahilbhattMS merged commit 10024e8 into master Jan 16, 2025
20 checks passed
@sahilbhattMS sahilbhattMS deleted the users/sahilbhatt/debug_monitor_tracing branch January 16, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants