Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example of how to disable device collection #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update example of how to disable device collection #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ appInsights.loadAppInsights();
```ts
import { ApplicationInsights } from '@microsoft/applicationinsights-web';

var RNPlugin = new ReactNativePlugin();
var RNPlugin = new ReactNativePlugin({
disableDeviceCollection: true
});
var appInsights = new ApplicationInsights({
config: {
instrumentationKey: 'YOUR_INSTRUMENTATION_KEY_GOES_HERE',
disableDeviceCollection: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at the current code this is a configuration is only used from the passed in configuration... The config that is passed to the constructor is actually never used.....

Which version are you using (older versions may have referenced it).

Based on what I just reviewed of the classes the correct approach is actually

  • Remove the "config" from the constructor as it's not used (unless it's referenced in another class -- I just looked at the manual one)
  • The config location "works" as currently defined, but would be more correctly located in the extensionConfig["AppInsightsReactNativePlugin"]: { disabeDeviceCollection: true; } which is where you will see it after initialization (and also where you can dynamically change it's value with the current version -- as we now expose all of the configurable values by exposing the internal defaults in their "true" location.

The reason it "works" (or at least it should be) being defined in the root (rather than in the extensionConfig) is historical and as long as the extension config is not also defined (by you) we still "support" reading and config specific value from the root of the config object.

extensions: [RNPlugin]
}
});
Expand Down
Loading