try to remove lint problem in tests (#146)

microsoft · Feb 13, 2024 · ca0bc05 · ca0bc05
1 parent 004df6e
commit ca0bc05
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/...ghts-angularplugin-mulple-instace.spec.ts → ...ts-angularplugin-multiple-instace.spec.ts b/...ghts-angularplugin-mulple-instace.spec.ts → ...ts-angularplugin-multiple-instace.spec.ts
@@ -14,7 +14,6 @@ import { Component, Injector } from "@angular/core";
 class FakeHomeComponent {}
 class FakeAboutComponent {}
 describe("ReactAI", () => {
-    let service: ApplicationinsightsAngularpluginErrorService;
     let fixture: ComponentFixture<AngularPlugin>;
     let angularPlugin: AngularPlugin;
     let analyticsPlugin: AnalyticsPlugin;
@@ -34,8 +33,6 @@ describe("ReactAI", () => {
     let analyticsPlugin4: AnalyticsPlugin;
     let core4: AppInsightsCore;
 
-    let analyticsPluginSpy: jasmine.SpyObj<AnalyticsPlugin>;
-
     const arg1: Injector = Injector.create({
         providers: [
             { provide: ApplicationinsightsAngularpluginErrorService, useClass: ApplicationinsightsAngularpluginErrorService }
@@ -75,12 +72,12 @@ describe("ReactAI", () => {
         angularPlugin3 = new AngularPlugin();
         angularPlugin4 = new AngularPlugin();
 
-
-        service = TestBed.inject(ApplicationinsightsAngularpluginErrorService);
+        // this is for analyticsPluginSpy
+        TestBed.inject(ApplicationinsightsAngularpluginErrorService);
         router = TestBed.inject(Router);
 
         // Get the spy on trackPageView from the spy object
-        analyticsPluginSpy = TestBed.inject(AnalyticsPlugin) as jasmine.SpyObj<AnalyticsPlugin>;
+        TestBed.inject(AnalyticsPlugin) as jasmine.SpyObj<AnalyticsPlugin>;
         fixture.detectChanges();
 
         // Setup
@@ -101,7 +98,7 @@ describe("ReactAI", () => {
             extensionConfig: {
                 [angularPlugin.identifier]: {useInjector: true }
             }
-        } as IConfig & IConfiguration, [angularPlugin, channel]);
+        } as IConfig & IConfiguration, [angularPlugin, analyticsPlugin, channel]);
 
         core2.initialize({
             instrumentationKey: "",
@@ -132,6 +129,10 @@ describe("ReactAI", () => {
 
         // clean up
         analyticsPlugin = undefined;
+        analyticsPlugin2 = undefined;
+        analyticsPlugin3 = undefined;
+        analyticsPlugin4 = undefined;
+
         core = undefined;
         channel = undefined;
         ApplicationinsightsAngularpluginErrorService.instance = null; // reset the singleton instance to null for re-assignment

diff --git a/...ninsights-angularplugin-js/src/lib/applicationinsights-angularplugin-js.component.spec.ts b/...ninsights-angularplugin-js/src/lib/applicationinsights-angularplugin-js.component.spec.ts
@@ -15,16 +15,13 @@ class FakeHomeComponent {}
 class FakeAboutComponent {}
 describe("ReactAI", () => {
 
-    let service: ApplicationinsightsAngularpluginErrorService;
     let fixture: ComponentFixture<AngularPlugin>;
     let angularPlugin: AngularPlugin;
     let analyticsPlugin: AnalyticsPlugin;
     let core: AppInsightsCore;
     let channel: ChannelPlugin;
     let router: Router;
 
-    let analyticsPluginSpy: jasmine.SpyObj<AnalyticsPlugin>;
-
     beforeEach(() => {
         const spy = jasmine.createSpyObj("AnalyticsPlugin", ["trackPageView"]);
         TestBed.configureTestingModule({
@@ -41,13 +38,14 @@ describe("ReactAI", () => {
             ]
         });
 
-        service = TestBed.inject(ApplicationinsightsAngularpluginErrorService);
+        TestBed.inject(ApplicationinsightsAngularpluginErrorService);
         fixture = TestBed.createComponent(AngularPlugin);
         angularPlugin = fixture.componentInstance;
         router = TestBed.inject(Router);
 
         // Get the spy on trackPageView from the spy object
-        analyticsPluginSpy = TestBed.inject(AnalyticsPlugin) as jasmine.SpyObj<AnalyticsPlugin>;
+        // analyticsPluginSpy
+        TestBed.inject(AnalyticsPlugin) as jasmine.SpyObj<AnalyticsPlugin>;
         fixture.detectChanges();
 
         // Setup