-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes to enable FIO and PostgreSQL tests in (Docker/ACI) container #435
base: main
Are you sure you want to change the base?
Conversation
A DiskManager that simply presents a OS disk, and does not try to do any discovery. Useful in containers.
… to FormatDisks/MountDisks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this POC, blocking in case of accidental check in. We will transform this into LinuxContainerDiskManager before checking in
…h dir to use on the disk Particularly useful when using the os disk
…n a container We won't have permission to change netfilter rules from within a container
Note that postgresql still doesn't work "out of the box", and we need a mock systemctl in the container image. However I decided to not bake that into VirtualClient - maybe the configure scripts in the package need to be updated.
|
Actually there is one more thing that need to be fixed - |
Note: the SuperuserPassword parameter change is not actually required, and since it causes CodeQL alert I can drop it |
Looks like unfortunately the sysbench postgresql tests still doesn't quite work:
|
Added a DummyDiskManager that just returns one root disk. However this is a TODO item - we want to make it use
df
to determine any additional volumes mounted to the container, and report correct filesystem size (makes more sense in ACI where it's the sandbox VHD's size), as well as any mounted volumes (need to experiment to see how volumes actually turn up in containers / ACI)Test command:
For some reason this currently still fails in Docker (testing TODO in ACI):
But works on WSL using
DOTNET_RUNNING_IN_CONTAINER=true
Not written any unit tests at this point, nor have I tested if the profile still works in a VM (I think it should)