browser: fix inconsistent automation errors #799
Merged
+260
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the extension relied on `chrome.windows.getCurrent()` to get the current window in view. However, when the devTools view is undocked, it is treated as the active window. This leads to errors where the service worker tries to send events to the devtools view instead of the content window. - There was an error where some code paths tried to access chrome.storage apis in the content script, causing the script to crash.
hillary-mutisya
temporarily deployed
to
development-fork
GitHub Actions
Inactive
hillary-mutisya
temporarily deployed
to
development-fork
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrome.windows.getCurrent()to get the current window in view. However, when the devTools view is undocked, it is treated as the active window. This leads to errors where the service worker tries to send events to the devtools view instead of the content window.