[PTRun][Calc]Add list separator handling for different cultures #36735
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htcfreek
reviewed
Jan 8, 2025
| @@ -123,7 +123,7 @@ private static string Translate(string input, CultureInfo cultureFrom, CultureIn | |||
| outputBuilder.Append( | |||
| decimal.TryParse(token, NumberStyles.Number, cultureFrom, out number) | |||
| ? (new string('0', leadingZeroCount) + number.ToString(cultureTo)) | |||
| : token); | |||
| : token.Replace(cultureFrom.TextInfo.ListSeparator, cultureTo.TextInfo.ListSeparator)); | |||
There was a problem hiding this comment.
Is cultureTo always en-us? Or is it set based on the output settings in plug-in settings?
There was a problem hiding this comment.
It can be any culture, since private Translate() is used by two functions: public Translate(), used for processing user input, where cultureTo is always en-US, but also by public TranslateBack() where cultureTo is CurrentCulture. I don't think that the result can contain a list separator though, so replacing probably happens only when cultureTo is en-US.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Replaces the current culture's list separator with the target culture's list separator in order to allow using functions with multiple arguments in locales where the list separator isn't
,. For examplepow(2;3)would be replaced withpow(2,3).PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Added unit tests, tested manually