Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New utility]Sysinternals ZoomIt #35880

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

jaimecbernardo
Copy link
Collaborator

@jaimecbernardo jaimecbernardo commented Nov 11, 2024

Summary of the Pull Request

This PR integrates the Sysinternals tool ZoomIt into PowerToys.
Has the PowerToys Settings page with the options allowed from ZoomIt.
Also updates some C++ dependencies.

Still missing/WIP:

  • spell check
  • Make it pass CI
  • OOBE page
  • Entries in Dashboard and quick access
  • Settings icons / images
  • Telemetry
  • Logging
  • Tweak copyright issues
  • Tweak Community.md
  • Verify what else might we need to localize
  • Test it more

PR Checklist

@jaimecbernardo
Copy link
Collaborator Author

Should timer color be preserved? It is only correct after I change some other timer setting

DrawMode sometimes fails to start properly, it takes the cursor and "freezes" the desktop, but there's no actual cursor and nothing happens on clicking. I can exit that mode on Esc as expected. Type mode works as expected when this happens. Also, pressing a button to change color brings the cursor up and everything starts working.

My cursor gets stuck unvisible when: ctrl+4 to enter live zoom mode press 2, select area and either save or cancel cursor is gone and stays gone until PT is closed

@stefansjfw , thank you for the review. Not sure if I tested it exactly as you, but this seems to be original ZoomIt behavior too. Have you tested with original ZoomIt too? https://learn.microsoft.com/pt-pt/sysinternals/downloads/zoomit

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work! all the issues I reported previously are actually original ZoomIt behavior

.github/actions/spell-check/expect.txt Fixed Show fixed Hide fixed
src/common/sysinternals/dll.c Fixed Show fixed Hide fixed
src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj Fixed Show fixed Hide fixed
src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj Fixed Show fixed Hide fixed
src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj Fixed Show fixed Hide fixed
src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj Fixed Show fixed Hide fixed

This comment has been minimized.

This comment has been minimized.

@jaimecbernardo
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaimecbernardo jaimecbernardo requested a review from a team as a code owner January 7, 2025 10:11

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants