Culture support for in operator and Sort function #2539
+783
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -737,23 +738,25 @@ public static Func<IRContext, FormulaValue[], FormulaValue> StringInOperator(boo | |||
|
|
|||
| var leftStr = (StringValue)left; | |||
| var rightStr = (StringValue)right; | |||
|
|
|||
| return new BooleanValue(irContext, rightStr.Value.IndexOf(leftStr.Value, exact ? StringComparison.Ordinal : StringComparison.OrdinalIgnoreCase) >= 0); | |||
There was a problem hiding this comment.
Does services always have a CultureInfo value? In other places where I see CultureInfo being accessed (mostly in LibraryText.txt) it comes from the runner directly, not from the service provider.
| return n1.Value.CompareTo(n2.Value) * compareToResultModifier; | ||
| var n2 = b.sortValue as TPFxPrimitive; | ||
| CultureInfo culture; | ||
| if (n1.Value is string n1s && n2.Value is string n2s && (culture = runner.GetService<CultureInfo>()) != null) |
…r-fx into gregli/culture-tr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inoperator andSortfunction were not culturally aware, resulting in incorrect results for Turkish and I'm sure other languages.The
Lower,Upper,Proper, andSortByColumnsfunctions are already culturally aware.Our regular expression functions are not culturally aware, but that is an interesting design choice that is the subject of #2538.
For testing, this PR adds the ability to change the culture in this local REPL only, with a
Languagefunction overload that takes a language tag as the first argument. Also added is a#SETUPhandler to specify the culture for a .txt test file.Removed
ToLowerfrom StringValue. It doesn't have enough context to do this on its own and be self contained, better to be very clear about how it is being done withCultureInfo.