Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use number of bins instead of quantization interval in mlos_bench tunables #835

Merged
merged 39 commits into from
Aug 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7f536a8
monkey patch ConfigSpace.Hyperparameter.sample_value() with value qua…
motus Aug 5, 2024
f54587e
add quantization to some tunables in unit tests
motus Aug 5, 2024
d4516db
Merge branch 'main' into sergiym/tunable/quantization
motus Aug 6, 2024
86e1557
use number of bins instead of quantization interval length in mlos_be…
motus Aug 6, 2024
61e9cc2
fix quantized_values to use quantization bins
motus Aug 6, 2024
de657a4
typo: accidentally removed quantization defs
motus Aug 7, 2024
ecc4b75
make tunable size tests work
motus Aug 7, 2024
5118454
minor fix to the grid search unit tests (new data type for cardinalit…
motus Aug 7, 2024
ef0486d
mypy fixes to grid search
motus Aug 7, 2024
565b3d7
disable pylint warning in _tunable_to_configspace
motus Aug 7, 2024
1c8ca09
minor docstring formatting
motus Aug 7, 2024
5087c94
Merge branch 'main' into sergiym/tunable/quantization_bins
motus Aug 7, 2024
28731c6
move monkey patching to a standalone function that can be used in uni…
motus Aug 8, 2024
2b6c863
better type annotations
motus Aug 8, 2024
6c5401b
add quantization to ConfigurationSpace parameters in unit tests
motus Aug 8, 2024
ebe8730
docstring formatting
motus Aug 8, 2024
6b76039
better parameter naming
motus Aug 8, 2024
3e984e1
docstring fix
motus Aug 8, 2024
1b13e2d
add quantization patching unit tests; bugfix in monkey patch code
motus Aug 8, 2024
d6eace8
imports formatting
motus Aug 8, 2024
eaddd89
add unit tests for repatching the same method multiple times
motus Aug 9, 2024
7c8efac
fix the repatching unit test
motus Aug 9, 2024
7e8c6b4
fix the repatching unit test
motus Aug 9, 2024
cff2eb7
try a new value of optim. score for FLAML
motus Aug 9, 2024
53befe4
new version of FLAML produces a different config
motus Aug 9, 2024
6e0133f
explicitly import RandomState to make pylint happy
motus Aug 9, 2024
a8fc00c
reorder imports
motus Aug 9, 2024
da8ab21
Update mlos_bench/mlos_bench/optimizers/convert_configspace.py
motus Aug 14, 2024
b3a5278
Update mlos_bench/mlos_bench/optimizers/convert_configspace.py
motus Aug 14, 2024
55cd8f4
roll back the change in unit tests due to (faulty) FLAML version
motus Aug 14, 2024
062482b
Merge branch 'main' into sergiym/tunable/quantization_bins
bpkroth Aug 14, 2024
f6fd392
Update mlos_bench/mlos_bench/tests/config/schemas/tunable-params/test…
motus Aug 14, 2024
1121eca
Merge branch 'main' into sergiym/tunable/quantization_bins
motus Aug 14, 2024
f5fbef1
black
bpkroth Aug 14, 2024
5a4f8a2
Some comments on potential misnomer issues with these attributes now
bpkroth Aug 14, 2024
deda931
remove old TODO
motus Aug 14, 2024
a3e1df5
update the quantization semantics to match the cardinality property; fix
motus Aug 15, 2024
2d241e7
make test_numerical_quantization work for quantized_values check
motus Aug 15, 2024
09a502a
add quantization_bins check
motus Aug 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable pylint warning in _tunable_to_configspace
motus committed Aug 7, 2024
commit 565b3d7224000b26cb3b665de32b2dfd2f3acc80
1 change: 1 addition & 0 deletions mlos_bench/mlos_bench/optimizers/convert_configspace.py
Original file line number Diff line number Diff line change
@@ -78,6 +78,7 @@ def _tunable_to_configspace(
cs : ConfigurationSpace
A ConfigurationSpace object that corresponds to the Tunable.
"""
# pylint: disable=too-complex
meta: Dict[Hashable, TunableValue] = {"cost": cost}
if group_name is not None:
meta["group"] = group_name