Add llamatune checks with quantized values #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are mainly to add flexibility to the auth service in supporting azure authenticating via: - A personal identity via az CLI for the local dev environment. This will still run into expiring issues, but is probably fine for local dev. - A personal or managed identity in an azure hosted environment. The flexibility to use the managed identity allows us to avoid the expiring issue without needing a separate SP, key-vault and cert setup, aligning with new security recommendations. --------- Co-authored-by: Eu Jing Chua <[email protected]> Co-authored-by: Sergiy Matusevych <[email protected]>
Mypy got updated to v 1.11 recently We need these mypy fixes to make other PRs pass the CI tests
Closes microsoft#785 Also, add more unit tests to make sure the optimizer handles string inputs correctly. --------- Co-authored-by: Brian Kroth <[email protected]>
…sergiym/opt/llamatune_inv
bpkroth
commented
Aug 8, 2024
motus
approved these changes
Aug 15, 2024
* move monkey_patch_quantization and its unit tests to mlos_core * SMAC suggests slightly different config now
motus
approved these changes
Aug 19, 2024
mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py
Outdated
Show resolved
Hide resolved
|
@motus concerned this isn't working quite right yet since the result output isn't quantized as expected (e.g., the test values that were reverted in the PR you made against mine in bpkroth#59). Let's start another PR to make sure that is working as expected and we get the quantization in the the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #812
Closes #813