build: Add depcheck tasks to some packages #23992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an alternative to the change explored in #23989.
In #22448 (comment) I outlined three options for inegrating depcheck into our builds. This change explores option 1, while #23989 explores option 2.
This change adds a new
check:depchecktask to the build, along with a declarative task to support incremental build. There is also a shared base config in the root of the repo. Packages can import this shared config and override/supplement the relevant bits.Finally, this change adds depcheck to three packages: presence and container-runtime in the client release group, and build-cli in the build-tools release group. Each package has its own config file and extends the base config.
If we proceed with this approach, we would onboard packages individually by adding the "check:depcheck" script to them.