Unused dependency checker and fixer #23989
+210
−46
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||
| /*! | ||||||
| * Copyright (c) Microsoft Corporation and contributors. All rights reserved. | ||||||
| * Licensed under the MIT License. | ||||||
| */ | ||||||
|
|
||||||
| // Enable TypeScript type-checking for this file. | ||||||
| // See https://www.typescriptlang.org/docs/handbook/intro-to-js-ts.html#ts-check | ||||||
| // @ts-check | ||||||
|
|
||||||
| // Import the shared config from the root of the repo. | ||||||
| import sharedConfig from "../../../knip.base.ts"; | ||||||
|
|
||||||
| export default { | ||||||
| include: [...sharedConfig.include], | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| ignoreDependencies: [ | ||||||
| ...sharedConfig.ignoreDependencies, | ||||||
|
|
||||||
| // Oclif plugins are used dynamically at runtime. | ||||||
| "@oclif/plugin-*", | ||||||
| // Danger is used at runtime in the dangerfile. | ||||||
| "danger", | ||||||
| // Types from this package are used in markdown.ts. | ||||||
| "mdast", | ||||||
| // This is needed by the fluid-build task integration in policy-check. | ||||||
| "tslib", | ||||||
| ], | ||||||
| }; | ||||||
|
There was a problem hiding this comment. I think most of the removed deps are actually used. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /*! | ||
| * Copyright (c) Microsoft Corporation and contributors. All rights reserved. | ||
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| // Enable TypeScript type-checking for this file. | ||
| // See https://www.typescriptlang.org/docs/handbook/intro-to-js-ts.html#ts-check | ||
| // @ts-check | ||
|
|
||
| export default { | ||
|
|
||
| // Knip has the capability to report many issue types. For now we are only using "dependencies" to check for unused dependency declaration in package.json | ||
| // In future, we can expand our requirements to report other issue types as well, for example: unused files, or unused exports etc. | ||
| // See: https://knip.dev/reference/cli#--include | ||
| include: ["dependencies"], | ||
| ignoreDependencies: [ | ||
| // The following deps are actually in use, but depcheck reports them unused. | ||
|
|
||
| // These packages are used in the CI pipelines. | ||
| "mocha-multi-reporters", | ||
| "moment", | ||
|
|
||
| // The following deps are reported as missing, but they are available. | ||
|
|
||
| // We use a 'hack' to make plugins from the shared eslint config available to our packages, those these deps are not | ||
| // directly needed in the package. | ||
| "@typescript-eslint/eslint-plugin", | ||
| "eslint-config-prettier", | ||
| "eslint-import-resolver-typescript", | ||
| "eslint-plugin-tsdoc", | ||
| "eslint-plugin-unicorn", | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a doc comment with a type directive here so we can get type checking on the config object. Something like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right it's typescript - just
import typethen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you can remove the ts-check-related comments.