-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Change API of staging mode #23974
base: test/staging-mode
Are you sure you want to change the base?
Draft: Change API of staging mode #23974
Conversation
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
return this.stagingModeHandle !== undefined; | ||
} | ||
enterStagingMode = (): ErasedType<"StagingModeHandle"> => { | ||
if (this.stagingModeHandle !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're using this handle to approximate a mutex. I would agree that mutually exclusive ownership of the staging mode state is a requirement, but I'd also argue that if the customer is in a state where they've lost sight of who might turn staging mode on/off then they're in trouble anyway. Having a failable enterStagingMode() seems annoying to account for on the customer side too, invites weird patterns like waitForAndEnableStagingMode().
I think the better solution is to keep it consolidated at the container runtime level in FF, and if the customer wants to broaden its visibility then they have the option to dole out the capability in whatever way fits their need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any thoughts on what that would look like? maybe create prototype, as i'm not sure how to do that is the abstract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, here's an example. Description has a second variation too:
#23982
No description provided.