-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run copy results after tests failures #23964
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR is focused on debugging why copy results are not running after test failures. Key changes include:
- Modifying a test assertion in DynamicComposedChart.test.tsx.
- Updating the pipeline condition in build-npm-client-package.yml to only check if startTest is true.
Reviewed Changes
File | Description |
---|---|
packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx | Changes the test assertion which now contradicts itself by expecting the element to be both null and defined. |
tools/pipelines/templates/build-npm-client-package.yml | Removes the succeededOrFailed() condition, which may prevent copying results when tests fail. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
https://dev.azure.com/fluidframework/public/_build/results?buildId=324912&view=ms.vss-test-web.build-test-results-tab shows a pipeline run in which jest tests failures are being show in the test tab. |
Updating pipeline conditions to run copy results even after tests failures.