Fix Shadow Mapping bug in MiniEngine for Non-legacy renderer #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adow mapping for non-legacy rendering path.
|
@microsoft-github-policy-service agree |
|
Before the patch, Sponza2.glTF:
After the patch:
|
|
Sorry I'm just getting around to this, and it reminded me of a bug someone fixed locally in one of our development branches. I just forwarded the bug fix to this repo's master branch. It affected Frustum.cpp. Can you try stashing your Frustum.cpp change, merge our latest, and see if your sun shadows are working correctly? They seem to work for me with the non-legacy renderer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of MiniEngine, for arbitrary .glTF models that use the non-legacy rendering path, shadow mapping is broken. The issue was caused by an incorrect orthogonal frustum being calculated for Shadow Cameras, in ../Frustum.cpp. This resulted in the Shadow Buffer containing little to no information due to frustum-culling of meshes with the incorrect frustum.
This patch fixes that bug, allowing for correct shadow mapping for .glTF file rendering in the non-legacy rendering path of MiniEngine!