Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EchoBot dotnet Sample #72

Closed
wants to merge 8 commits into from
Closed

Conversation

rido-min
Copy link
Member

No description provided.

@rido-min rido-min requested a review from a team as a code owner February 27, 2025 19:45
@rido-min rido-min marked this pull request as draft February 27, 2025 19:45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here. We should add appsettings.Development and appsetting.Production to .gitignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appSettings.Development can be used to share settings across a team, hence it's not gitignored. And more importantly it will be included in the packaged app for deployment. What is a bad security practice.

@tracyboehrer
Copy link
Member

My only issue with this is Matt wants to push the DotNet Application merge early next week, and that will then be a new sample. So this work will be short lived.

@rido-min
Copy link
Member Author

My only issue with this is Matt wants to push the DotNet Application merge early next week, and that will then be a new sample. So this work will be short lived.

same as with docs. Once we have the application object we will update it MyBot.cs. The main point of this PR is not the sample itself, rather the infra: CI, Feeds, CodeSpaces, alignment across languages, etc..

@rido-min rido-min marked this pull request as ready for review March 3, 2025 17:53
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if having 2 CI is the right thing (we could also add some path filters), or just build ALL samples across languages in a single GHAction.

@tracyboehrer
Copy link
Member

Closing due to AgentApplication version of this sample having been merged instead. Thanks for the effort though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants