-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EchoBot dotnet Sample #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here. We should add appsettings.Development and appsetting.Production to .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appSettings.Development can be used to share settings across a team, hence it's not gitignored. And more importantly it will be included in the packaged app for deployment. What is a bad security practice.
My only issue with this is Matt wants to push the DotNet Application merge early next week, and that will then be a new sample. So this work will be short lived. |
same as with docs. Once we have the application object we will update it MyBot.cs. The main point of this PR is not the sample itself, rather the infra: CI, Feeds, CodeSpaces, alignment across languages, etc.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if having 2 CI is the right thing (we could also add some path filters), or just build ALL samples across languages in a single GHAction.
Closing due to AgentApplication version of this sample having been merged instead. Thanks for the effort though. |
No description provided.