Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of Windows (Server and Platform SDK) 2003 #2451

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove mentions of Windows (Server and Platform SDK) 2003 #2451

merged 1 commit into from
Jan 8, 2025

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jan 7, 2025

I left in

pywin32/win32/Lib/winioctlcon.py

Lines 1056 to 1059 in 0aadef0

## DISK_WRITE_CACHE_STATE - ?????? this enum has disappeared from winioctl.h in windows 2003 SP1 sdk ??????
DiskWriteCacheNormal = 0
DiskWriteCacheForceDisable = 1
DiskWriteCacheDisableNotSupported = 2
since that would be tackled in a winioctlcon.py regeneration.

mhammond
mhammond approved these changes Jan 8, 2025
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Avasam Avasam merged commit ca86554 into mhammond:main Jan 8, 2025
30 checks passed
@Avasam Avasam deleted the Remove-Windows-2003 branch January 8, 2025 01:28
@Avasam Avasam mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @mhammond