Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(na): update change pass screenshot and links in release notes and access pages #1765

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mrjones-plip
Copy link
Contributor

@mrjones-plip mrjones-plip commented Feb 5, 2025

Description

I went to go check out the release notes for 4.17 and noticed that there was no screenshot. I installed 4.17 locally, made a screenshot, then I realized that the existing screenshot we had wasn't accurate to the workflow that ended up shipping in 4.17. I ended redoing the existing screenshot and then adding it in release notes.

I also noticed in the reference docs we said this feature shipped in 4.16, but it shipped in 4.17. This is now fixed

Finally, the new screenshots are in the "i'm on a phone" style screenshot and are transparent so don't render with a white background when docs site is in dark mode.

Before and after shots

Before is on top, after is on bottom

Release notes

release notes

Access page

access page

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@mrjones-plip mrjones-plip marked this pull request as ready for review February 5, 2025 21:53
@mrjones-plip mrjones-plip requested a review from jkuester February 5, 2025 22:00
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Pro-level! 📽️

@mrjones-plip mrjones-plip merged commit b49e1fa into main Feb 5, 2025
2 checks passed
@mrjones-plip mrjones-plip deleted the update-change-pass-image-links branch February 5, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants