Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update box model Module to contain the correct properties #37536

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jacobcassidy
Copy link
Contributor

Description

Removes sizing properties (height, width, etc) which are part of the box sizing Module, not the box model Module.

Motivation

Corrects the information given to readers to match the W3C specs for the box model Module.

Additional details

See: https://drafts.csswg.org/css-box/#property-index and https://drafts.csswg.org/css-sizing/#property-index

@jacobcassidy jacobcassidy requested a review from a team as a code owner January 7, 2025 01:39
@jacobcassidy jacobcassidy requested review from estelle and removed request for a team January 7, 2025 01:39
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/CSS_box_model
Title: CSS box model
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit aeb74a6 into mdn:main Jan 9, 2025
7 checks passed
@jacobcassidy jacobcassidy deleted the css-box-model-update branch January 9, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants