Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental features fixes #37156

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Dec 9, 2024

The experimental features page has a bunch of errors, reported in #36742. This fixes the following ones:

@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Dec 9, 2024
@@ -218,7 +218,6 @@ This feature renders control characters (Unicode category Cc) other than _tab_ (
<tr>
<th>Preference name</th>
<td colspan="2">
<code>layout.css.control-characters.enabled</code> or
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout.css.control-characters.enabled is no longer in source. Just removed it because the other one (layout.css.control-characters.visible) is. This is still in spec etc according to https://bugzilla.mozilla.org/show_bug.cgi?id=1790223#c4 and will go live when other vendors catch up to spec

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Preview URLs

(comment last updated: 2024-12-10 00:21:12)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Dec 10, 2024
Comment on lines -948 to -988
### SVGPathSeg APIs

The SVGPathSeg APIs are being unshipped, and have been placed behind a preference.
This includes: `SVGPathSegList`, [SVGPathElement.getPathSegAtLength()](/en-US/docs/Web/API/SVGPathElement), `SVGAnimatedPathData`.
(See [Firefox bug 1388931](https://bugzil.la/1388931) for more details.)

<table>
<thead>
<tr>
<th>Release channel</th>
<th>Version removed</th>
<th>Enabled by default?</th>
</tr>
</thead>
<tbody>
<tr>
<th>Nightly</th>
<td>97</td>
<td>No</td>
</tr>
<tr>
<th>Developer Edition</th>
<td>97</td>
<td>No</td>
</tr>
<tr>
<th>Beta</th>
<td>97</td>
<td>No</td>
</tr>
<tr>
<th>Release</th>
<td>97</td>
<td>No</td>
</tr>
<tr>
<th>Preference name</th>
<td colspan="2"><code>dom.svg.pathSeg.enabled</code></td>
</tr>
</tbody>
</table>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disabled a feature and was subsequently removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1745149. I separately fixed up BCD.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Dec 10, 2024
Comment on lines -1213 to -1251
#### Hit regions

Whether the mouse coordinates are within a particular area on the canvas is a common problem to solve. The hit region API allows you to define an area of your canvas and provides another possibility to expose interactive content on a canvas to accessibility tools.

<table>
<thead>
<tr>
<th>Release channel</th>
<th>Version added</th>
<th>Enabled by default?</th>
</tr>
</thead>
<tbody>
<tr>
<th>Nightly</th>
<td>30</td>
<td>No</td>
</tr>
<tr>
<th>Developer Edition</th>
<td>30</td>
<td>No</td>
</tr>
<tr>
<th>Beta</th>
<td>30</td>
<td>No</td>
</tr>
<tr>
<th>Release</th>
<td>30</td>
<td>No</td>
</tr>
<tr>
<th>Preference name</th>
<td colspan="2"><code>canvas.hitregions.enabled</code></td>
</tr>
</tbody>
</table>
Copy link
Collaborator Author

@hamishwillee hamishwillee Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pref canvas.hitregions.enabled is no longer present. The methods it was added to gate are also not preset - see https://bugzilla.mozilla.org/show_bug.cgi?id=966591, so I assume this was removed when it was decided not to proceed with that feature.

@hamishwillee hamishwillee marked this pull request as ready for review December 10, 2024 00:24
@hamishwillee hamishwillee requested a review from a team as a code owner December 10, 2024 00:24
@hamishwillee hamishwillee requested review from pepelsbey and removed request for a team December 10, 2024 00:24
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit c63a502 into mdn:main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants