Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pages: DOMTokenList and MediaList toString() method #37052

Merged
merged 13 commits into from
Dec 21, 2024
Merged

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 2, 2024

@estelle estelle requested a review from a team as a code owner December 2, 2024 23:29
@estelle estelle requested review from sideshowbarker and removed request for a team December 2, 2024 23:29
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

@estelle estelle requested review from wbamberg and Josh-Cena December 2, 2024 23:39
files/en-us/web/api/domtokenlist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domtokenlist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domtokenlist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/domtokenlist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/medialist/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/medialist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/medialist/tostring/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/medialist/tostring/index.md Outdated Show resolved Hide resolved
Comment on lines 53 to 55
- {{domxref("MediaList.mediaText")}}
- {{domxref("MediaList.appendMedium()")}}
- {{domxref("MediaList")}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I doubt the value of see-alsoing the interface or its other members.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I include links to the methods used in the example within

@sideshowbarker sideshowbarker removed their request for review December 16, 2024 08:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from wbamberg December 16, 2024 21:17
@Josh-Cena Josh-Cena removed their request for review December 18, 2024 06:15
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit 494edeb into main Dec 21, 2024
9 checks passed
@wbamberg wbamberg deleted the stringifiers branch December 21, 2024 04:29
allan-bonadio pushed a commit to allan-bonadio/content that referenced this pull request Dec 25, 2024
* New pages: DOMTokenList and MediaList toString() method

* landing page links to the new pages

* Update index.md

* Update index.md

* Update files/en-us/web/api/domtokenlist/tostring/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/domtokenlist/tostring/index.md

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/domtokenlist/tostring/index.md

* Update files/en-us/web/api/medialist/index.md

Co-authored-by: wbamberg <[email protected]>

* Apply suggestions from code review

Co-authored-by: wbamberg <[email protected]>

* Update files/en-us/web/api/medialist/tostring/index.md

Co-authored-by: wbamberg <[email protected]>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/medialist/tostring/index.md

* Apply suggestions from code review

Co-authored-by: wbamberg <[email protected]>

---------

Co-authored-by: wbamberg <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants