Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pages: CSS SVG filter properites #36783

Merged
merged 3 commits into from
Nov 14, 2024
Merged

New pages: CSS SVG filter properites #36783

merged 3 commits into from
Nov 14, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 14, 2024

@estelle estelle requested review from a team as code owners November 14, 2024 01:08
@estelle estelle requested review from chrisdavidmills and removed request for a team November 14, 2024 01:08
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024


## Formal definition

{{CSSInfo}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing data


## Formal definition

{{CSSInfo}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here & probably below

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks. A couple of comments & missing formal definition, but leaving a +1 👍🏻

@estelle estelle merged commit b7bf812 into main Nov 14, 2024
9 checks passed
@estelle estelle deleted the svg branch November 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants