Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: css inline layout #36582

Merged
merged 3 commits into from
Nov 11, 2024
Merged

New module: css inline layout #36582

merged 3 commits into from
Nov 11, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 30, 2024 •
edited
Loading

new landing page (it was missing)

@estelle estelle requested review from a team as code owners October 30, 2024 22:22
@estelle estelle requested review from chrisdavidmills and removed request for a team October 30, 2024 22:22
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed labels Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-11-08 23:18:07)

@estelle estelle mentioned this pull request Oct 30, 2024
Open
chrisdavidmills
chrisdavidmills requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle a few suggestions. Mostly looking good!

files/en-us/glossary/baseline/typography/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/baseline/typography/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/baseline/typography/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_inline_layout/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle perfect! Let's get this merged.

@chrisdavidmills chrisdavidmills merged commit 58dd075 into main Nov 11, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the css_inline branch November 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills