Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU - Add secure context info #26268

Merged
merged 2 commits into from
Apr 18, 2023
Merged

WebGPU - Add secure context info #26268

merged 2 commits into from
Apr 18, 2023

Conversation

hamishwillee
Copy link
Collaborator

This adds WebGPU to the list of APIs that require a secure context, and also adds the secure-context header to the API page.

May not be necessary, but I also added a "Security Requirement" section that reflects this same information. Trying to do the right thing for the future.

@Elchi3 @chrisdavidmills Appreciate your comments.

Other FF113 docs work for this can be tracked in #26157

@hamishwillee hamishwillee requested review from a team as code owners April 18, 2023 04:55
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team April 18, 2023 04:55
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Apr 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

Preview URLs

(comment last updated: 2023-04-18 10:00:17)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, apart from one comment.

I like the idea of just adding the banner to the main API page; I kind of ignored it originally, because I thought adding it to all the pages was a bit to obtrusive.

files/en-us/web/api/webgpu_api/index.md Outdated Show resolved Hide resolved
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both, looks great to me! 👍

@Elchi3 Elchi3 merged commit f93bc37 into mdn:main Apr 18, 2023
@hamishwillee hamishwillee deleted the webgpu_secure branch April 20, 2023 23:40
@hamishwillee
Copy link
Collaborator Author

I like the idea of just adding the banner to the main API page; I kind of ignored it originally, because I thought adding it to all the pages was a bit to obtrusive.

@chrisdavidmills Yes, the rule is to the main API page. If there is a gating accessor method/property I sometimes add it there too - because that is where people will discover it. But otherwise adding everywhere is frowned upon.

That said I hope one day we automate getting the context metadata automatically, apply it to all pages where it is relevant, and have a much smaller icon to indicate that secure context applies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants