-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPU - Add secure context info #26268
Conversation
Preview URLs
(comment last updated: 2023-04-18 10:00:17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, apart from one comment.
I like the idea of just adding the banner to the main API page; I kind of ignored it originally, because I thought adding it to all the pages was a bit to obtrusive.
Co-authored-by: Chris Mills <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both, looks great to me! 👍
@chrisdavidmills Yes, the rule is to the main API page. If there is a gating accessor method/property I sometimes add it there too - because that is where people will discover it. But otherwise adding everywhere is frowned upon. That said I hope one day we automate getting the context metadata automatically, apply it to all pages where it is relevant, and have a much smaller icon to indicate that secure context applies |
This adds WebGPU to the list of APIs that require a secure context, and also adds the secure-context header to the API page.
May not be necessary, but I also added a "Security Requirement" section that reflects this same information. Trying to do the right thing for the future.
@Elchi3 @chrisdavidmills Appreciate your comments.
Other FF113 docs work for this can be tracked in #26157