Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inset-area renamed to position-area #24073

Closed

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Aug 9, 2024

DO NOT MERGE THIS UNTIL THE ASSOCIATED DOCS UPDATES ARE DONE: see mdn/content#35390

Summary

The CSS Anchor Positioning inset-area property has been renamed to positioned-area. See the change discussion, and the position-area spec definition.

I have been told by Chrome engineering that position-area is being added alongside inset-area as of Chrome 129, and they are removing it around Chrome 132-ish (I'll make changes related to that in a subsequent PR).

Test results and supporting details

Related issues

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. labels Aug 9, 2024
@chrisdavidmills chrisdavidmills requested a review from Elchi3 August 9, 2024 18:02
@chrisdavidmills
Copy link
Contributor Author

@Elchi3 ack. I just noticed that you've already submitted a PR for this; sorry about that. Before closing, you might want to check mine to see if there is anything else you should include in yours.

@Elchi3
Copy link
Member

Elchi3 commented Aug 12, 2024

Thanks Chris, my PR is more minimal as it doesn't record any data about Chrome 129 yet. (there is no beta for 129 just yet and we can't yet verify if the rename really ships in 129).

The fact that you had to add new entries to the browser/ folder is a good warning sign that compat data is being added prematurely. So, my recommendation would be to merge my PR and wait until we're in the 129 beta cycle for any other changes. Does that make sense?

@chrisdavidmills
Copy link
Contributor Author

Thanks Chris, my PR is more minimal as it doesn't record any data about Chrome 129 yet. (there is no beta for 129 just yet and we can't yet verify if the rename really ships in 129).

The fact that you had to add new entries to the browser/ folder is a good warning sign that compat data is being added prematurely. So, my recommendation would be to merge my PR and wait until we're in the 129 beta cycle for any other changes. Does that make sense?

@Elchi3 that works for me. Get yours merged, and let me know when that happens, then I'll merge the corresponding content PR. Then let's revisit this once the 129 beta cycle starts.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 15, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Aug 15, 2024
@Elchi3
Copy link
Member

Elchi3 commented Aug 15, 2024

@chrisdavidmills can you review #23993? That could land and then I can see about Chrome 129 next week with a collector run.

@chrisdavidmills
Copy link
Contributor Author

@chrisdavidmills can you review #23993? That could land and then I can see about Chrome 129 next week with a collector run.

Done!

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 15, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@Elchi3
Copy link
Member

Elchi3 commented Aug 23, 2024

Closing in favor of #24210

@Elchi3 Elchi3 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants