Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New_feature: hightlight conflict numbers. #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QingZhouCheng
Copy link

No description provided.

@mayerui
Copy link
Owner

mayerui commented Oct 15, 2024

你好,我觉得conflict warning的点子很好。在review和实际游玩的过程中发现几点需要再考虑一下:

  1. 游戏设计问题。conflict是在每次填数字的时候进行检查和提示,还是在用户输入回车打算结束游戏时检查和提示?我觉得也许后者比较合理,或者根据难度区分两种策略?
  2. 新增的State::CONFLICT状态标志。我注意到这个状态与INITED、ERASED并列作为枚举值,但其实CONFLICT和ERASED是可以共存的对吗?是否单独设置一个bool类型标志更合理。
  3. CONFLICT状态是会同时受到填数、擦除两种动作影响的,但目前的commit中只考虑了填数时当前格的状态变化,未考虑擦除时同单元其他格的状态恢复。比如这个场景下,后填的1是CONFLICT状态,显示为红色;擦除绿色1后,红色1实际上已经没有冲突了,但并未恢复为绿色。
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants