Raise PHPStan level to 10

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-  level: 9
+  level: 10
   reportUnmatchedIgnoredErrors: false
   paths:
     - src

src/Application.php

@@ -19,6 +19,10 @@ class Application extends SymfonyApplication
 
     public function __construct(Container $container)
     {
+        // TODO: Drop these and declare const type once we move to PHP 8.3
+        assert(is_string(static::APP_NAME));
+        assert(is_string(static::APP_VERSION));
+
         $this->container = $container;
         parent::__construct(static::APP_NAME, static::APP_VERSION);
     }

src/Linter/LinterConfiguration.php

@@ -114,6 +114,8 @@ public function getConfigTreeBuilder(): TreeBuilder
             $root = $treeBuilder->root('typoscript-lint'); // @phpstan-ignore-line
         }
 
+        // This is a mess; I won't bother teaching PHPStan how to interpret this
+        // @phpstan-ignore-next-line
         $root
             ->children()
             ->arrayNode('paths')

src/Linter/Sniff/DeadCodeSniff.php

@@ -31,6 +31,8 @@ public function __construct(array $parameters)
      */
     public function sniff(array $tokens, File $file, LinterConfiguration $configuration): void
     {
+        assert(is_string(static::ANNOTATION_COMMENT));
+
         foreach ($tokens as $token) {
             if (!($token->getType() === TokenInterface::TYPE_COMMENT_ONELINE
                 || $token->getType() === TokenInterface::TYPE_COMMENT_MULTILINE)) {

src/Linter/Sniff/NestingConsistencySniff.php

@@ -13,7 +13,7 @@ public function __construct(array $parameters)
     {
         parent::__construct($parameters);
 
-        if (array_key_exists('commonPathPrefixThreshold', $parameters)) {
+        if (array_key_exists('commonPathPrefixThreshold', $parameters) && is_int($parameters['commonPathPrefixThreshold'])) {
             $this->commonPathPrefixThreshold = $parameters['commonPathPrefixThreshold'];
         }
     }

src/Linter/Sniff/SniffLocator.php

@@ -16,8 +16,6 @@ class SniffLocator
      *
      * @return SniffInterface[]
      * @throws Exception
-     *
-     * @psalm-return array<int, SniffInterface>
      */
     private function loadSniffs(LinterConfiguration $configuration): array
     {

src/Linter/Sniff/Visitor/NestingConsistencyVisitor.php

@@ -6,6 +6,7 @@
 use Helmich\TypoScriptLint\Linter\Sniff\NestingConsistencySniff;
 use Helmich\TypoScriptParser\Parser\AST\ConditionalStatement;
 use Helmich\TypoScriptParser\Parser\AST\NestedAssignment;
+use Helmich\TypoScriptParser\Parser\AST\ObjectPath;
 use Helmich\TypoScriptParser\Parser\AST\Operator\Assignment;
 use Helmich\TypoScriptParser\Parser\AST\Statement;
 
@@ -63,7 +64,7 @@ private function walkStatementList(array $statements): void
         // Step 2: Discover all plain assignments and determine whether any of them
         // can be moved within one of the nested assignments.
         foreach ($statements as $statement) {
-            if (!isset($statement->object)) {
+            if (!isset($statement->object) || !($statement->object instanceof ObjectPath)) {
                 continue;
             }
 
@@ -158,7 +159,7 @@ private function getAssignedObjectPathsFromStatementList(array $statements): arr
 
         // Step 1: Discover all nested object assignment statements.
         foreach ($statements as $statement) {
-            if (!isset($statement->object)) {
+            if (!isset($statement->object) || !($statement->object instanceof ObjectPath)) {
                 continue;
             }
 

src/Util/Finder.php

@@ -58,6 +58,7 @@ public function getFilenames(
 
         $matchesPatternList = fn(array $patterns): callable => function (string $file) use ($patterns): bool {
             foreach ($patterns as $pattern) {
+                assert(is_string($pattern));
                 if (fnmatch($pattern, $file)) {
                     return true;
                 }