Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates - and remove body printing #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Twilio/APIKey.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module Twilio.APIKey
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some errors like

src/Twilio/Types/SID/TH.hs:59:6:
    Not in scope: ‘<>’
    Perhaps you meant one of these:
      ‘<$>’ (imported from Prelude), ‘*>’ (imported from Prelude),
      ‘<$’ (imported from Prelude)

So I think we need to add these imports back.

import Data.Text (Text)
import Data.Time.Clock

Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Account.hs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module Twilio.Account
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Address.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import Control.Error.Safe
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)

import Control.Monad.Twilio
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Application.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module Twilio.Application
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import qualified Data.Text as T
import Data.Time.Clock
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/AuthorizedConnectApp.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module Twilio.AuthorizedConnectApp
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import qualified Data.Text as T
import Data.Time.Clock
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/AvailablePhoneNumbers.hs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module Twilio.AvailablePhoneNumbers
import Control.Applicative
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import qualified Data.Text as T

import Control.Monad.Twilio
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Call.hs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import Control.Error.Safe
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Call/Feedback.hs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Scientific
import Data.Time.Clock
import GHC.Generics
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Conference.hs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module Twilio.Conference
import Control.Monad
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import GHC.Generics
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Conference/Participant.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module Twilio.Conference.Participant
import Control.Monad
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Time.Clock
import GHC.Generics
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Conference/Participants.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import Control.Applicative
import Data.Aeson
import Data.Data
import Data.Maybe
import Data.Monoid
import GHC.Generics

import Twilio.Conference.Participant
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/ConnectApp.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module Twilio.ConnectApp
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import qualified Data.Text as T
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/IncomingPhoneNumber.hs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module Twilio.IncomingPhoneNumber
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
2 changes: 1 addition & 1 deletion src/Twilio/Internal/Request.hs
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ runRequest' credentials (RequestT (FreeT m)) = m >>= \case
else do
let body = responseBody response
body' <- LBS.fromChunks <$> brConsume body
print body'
-- print body'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to just delete this, IMO.

go $ const body' <$> response
1 change: 0 additions & 1 deletion src/Twilio/Message.hs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module Twilio.Message
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Message/Media.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module Twilio.Message.Media
import Control.Monad
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import GHC.Generics
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Message/MediaList.hs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import Control.Applicative
import Data.Aeson
import Data.Data
import Data.Maybe
import Data.Monoid
import GHC.Generics

import Twilio.Internal.Request
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/OutgoingCallerID.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module Twilio.OutgoingCallerID
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Queue.hs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import GHC.Generics
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Queue/Member.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module Twilio.Queue.Member
import Control.Monad
import Data.Aeson
import Data.Data
import Data.Monoid
import Data.Time.Clock
import GHC.Generics
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Queue/Members.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import Control.Applicative
import Data.Aeson
import Data.Data
import Data.Maybe
import Data.Monoid
import GHC.Generics

import Twilio.Queue.Member
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Recording.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import Control.Error.Safe
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Time.Clock
import Network.URI

Expand Down
1 change: 0 additions & 1 deletion src/Twilio/ShortCode.hs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module Twilio.ShortCode
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Transcription.hs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import Control.Error.Safe
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Types.hs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import Control.Monad
import Control.Monad.Reader.Class
import Data.Aeson
import qualified Data.ByteString.Char8 as C
import Data.Monoid
import Data.Text (Text)
import qualified Data.Text as T
#if MIN_VERSION_http_client(0,5,0)
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Types/SID.hs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import Data.Bits (countLeadingZeros)
import Data.Data (Data, Typeable)
import Data.Hashable (Hashable)
import Data.Ix (Ix)
import Data.Monoid ((<>))
import Data.String (IsString(fromString))
import Data.Text (Text)
import qualified Data.Text as T
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/Types/SID/TH.hs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ module Twilio.Types.SID.TH
( createSID
) where

import Data.Monoid ((<>))
import Language.Haskell.TH
#if MIN_VERSION_template_haskell(2,11,0)
( Bang(..)
Expand Down
1 change: 0 additions & 1 deletion src/Twilio/UsageTrigger.hs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module Twilio.UsageTrigger
import Control.Monad
import Control.Monad.Catch
import Data.Aeson
import Data.Monoid
import Data.Text (Text)
import Data.Time.Clock
import Network.URI
Expand Down
2 changes: 1 addition & 1 deletion stack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# resolver:
# name: custom-snapshot
# location: "./custom-snapshot.yaml"
resolver: lts-8.20
resolver: lts-13.2

# User packages to be built.
# Various formats can be used as shown in the example below.
Expand Down
1 change: 0 additions & 1 deletion test/api/Test.hs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
module Main where

import Control.Monad.IO.Class
import Data.Monoid
import Data.Maybe (fromMaybe)
import Data.Text (Text, unpack, pack)
import Network.URI
Expand Down
2 changes: 1 addition & 1 deletion twilio.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ library
base ==4.*,
binary >=0.7,
bytestring ==0.10.*,
containers ==0.5.*,
containers >= 0.5.0 && <0.7.0,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can just nix the upper bound completely?

deepseq >=1,
errors >=1,
exceptions ==0.*,
Expand Down