Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish translation for the latest 4th edition. #580

Open
wants to merge 120 commits into
base: master
Choose a base branch
from

Conversation

arsahindev
Copy link

@arsahindev arsahindev commented Mar 24, 2024

Turkish translation.

@arsahindev arsahindev marked this pull request as ready for review December 17, 2024 16:45
@arsahindev arsahindev changed the title ONGOING Turkish translation for the latest 4th edition. Turkish translation for the latest 4th edition. Dec 17, 2024
@arsahindev
Copy link
Author

arsahindev commented Dec 17, 2024

Hi there @marijnh , I've finalized my efforts regarding the Turkish translation. How shall we continue?
I've opened the PR to master since I couldn't find the 4th_edition branch. Apparently you've removed it and merged with 4th branch since the 4th is the most recent one.

@marijnh
Copy link
Owner

marijnh commented Dec 17, 2024

Nice! Do you want to host it yourself, or shall I set up a build from your repository on my server?

@arsahindev
Copy link
Author

arsahindev commented Dec 17, 2024

Nice! Do you want to host it yourself, or shall I set up a build from your repository on my server?

Hmm, I just looked into the translations of other people and they're all hosting it by themselves, I would like to do it myself as well.
That would be good practice for learning static website hosting. :)

I guess this means I don't need this PR merged then, if so I can close it and let you know when I host it? But there still needs to be a change to add a link to the hosted Turkish version of the book I believe.
I'll contact you for help in case I get stuck on an issue while hosting.

@marijnh
Copy link
Owner

marijnh commented Dec 17, 2024

Yes, let's keep this open, to track adding the link. I could point tr.eloquentjavascript.net at your server if you want, or you can use some other URL.

@arsahindev
Copy link
Author

Hi again, I've been having issues with the make html command and couldn't find the issue with it.
Here's the video of the issue.

@marijnh
Copy link
Owner

marijnh commented Jan 2, 2025

You seem to have removed the backslashes from the quotes inside the quoted string on this line, making it invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants