Add blisko source #3011
Add blisko source #3011
Conversation
|
I do not like that you need to provide ids you need to obtain yourself. You could then hardcode a list of ownerIDs to select from or provide your own (the edpevent_se source does basically the same). And you can then add them to EXTRA_INFO so they show up in the README and source selection This way users can just search for their area and have an easy way to search for their region I found some IDs to use: List of regions I found
Found IDs usingimport requests
import time
url = "https://gateway.sisms.pl/akun/api/owners/{id}/info"
for i in range(300):
r = requests.get(url.format(id=i))
if r.status_code != 200:
# print(i, "not found")
continue
data = r.json()
if "TIMETABLE" not in data["tabs"]:
print(i, data.get("NAME", "no name"), "has no timetable")
continue
print(i, data["name"])
time.sleep(.1) |
|
Oh man that's awesome; thanks a lot for that. I'll adjust the PR later today. |
Provide a helper utility to find `formattedId`
|
@5ila5 Update PR; I've added a helper script https://github.com/btaczala/hacs_waste_collection_schedule/blob/blisko/custom_components/waste_collection_schedule/waste_collection_schedule/service/Blisko_searcher.py that can/must be used to figure out |
|
I like your script, but we try to move away from these kinds of scripts as a lot of seem to not be able to run them properly, so I think integrating this functionality directly in the source is a better idea as it integrates better in the GUI configuration. I still think hard-coding the region is the way to go: Hardcoded regions and allow directly passing region, city, street, house_number arguments: def __init__(
self,
regionId: str | int | None = None,
formattedId: str | None = None,
region: str | None = None,
city: str | None = None,
street: str | None = None,
house_number: str | None = None,
):and then some checks like if not regionId:
if not region:
raise SourceArgumentRequiredWithSuggestions(
argument="region",
message="Region or Region ID is required",
suggestions=[str(region["region_name"]) for region in REGIONS],
)
for region_item in REGIONS:
if region.replace(" ", "") == region_item[
"region_name"
].lower().replace(" ", ""):
regionId = region["id"]
breakand calling your funtions from the script (maybe a bit modified to better fit this use case). you could put them into the service folder. verifing the arguments and setting the attribute I know it isn't quite as clean but we do not have a good way to show custom wizards to configure sources throug the GUI (and I don't have that much time to work on one atm.) |
| if args.region and args.city: | ||
| streets_json = all_street_per_city(args.region, args.city) | ||
| if streets_json: | ||
| print(streets_json) |
There was a problem hiding this comment.
Printing with print(json.dumps(streets_json, indent=2)) produces a way better readable result
(same in other printing functions)
|
I think one piece is missing. In such case, we should directly request town addresses: In result, we can use the formatted town address, like this: Other than that, great job! I tested it, and it works fine. |
|
Done in bb49ada 😄 |
|
What about my comment above? Are you interested in implementing it that way? I'd still prefer this approach, but the current state is usable and making it more user-friendly could be done when there is a way to have real custom configuration forms in the GUI setup. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@5ila5 yeah sure I can restructure that in a way that fits project needs. Will try to change it during the weekend. |
|
@5ila5 I've tried to implement as you described but to be honest I don't completly understand what you mean. I get that regions can be hardcoded and we can search region defined as name in cached regions but I have no idea how to further figure out formattedId ( or help the user to figure it out). I agree that fully UI flow for configuration would be nice but I have no idea how to achive that. PS. Sorry it took me so long to respond. |
|
I meant hard-coding Region names and accept a region name instead of an ID in the init and translate it to the id. There is currently no way to design a fully interactive config flow but you can raise an WithSuggestions errors from this list https://github.com/mampfes/hacs_waste_collection_schedule/blob/master/doc/contributing_source.md#exceptions which will then suggest alternative values in the GUI |
No description provided.