-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conv1d #506
base: master
Are you sure you want to change the base?
Conversation
@@ -13,3 +13,4 @@ MacroTools 0.3.6 | |||
AutoHashEquals 0.1.0 | |||
MLDatasets 0.3.0 | |||
SpecialFunctions 0.7.0 | |||
Optim 0.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now delete the REQUIRE file
@@ -135,6 +135,7 @@ with_tape | |||
|
|||
|
|||
using Distributed | |||
using Optim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in This PR?
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
========================================
- Coverage 54.7% 53.2% -1.5%
========================================
Files 86 83 -3
Lines 2702 2654 -48
========================================
- Hits 1478 1412 -66
- Misses 1224 1242 +18
Continue to review full report at Codecov.
|
Rebased version of #480