forked from opendatahub-io/opendatahub-operator
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: support kserve with authorino #12
Closed
aslakknutsen
wants to merge
22
commits into
maistra:service-mesh-integration
from
aslakknutsen:service-mesh-integration
Closed
FEAT: support kserve with authorino #12
aslakknutsen
wants to merge
22
commits into
maistra:service-mesh-integration
from
aslakknutsen:service-mesh-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aslakknutsen
commented
Oct 3, 2023
- Activate extauth for grpc traffic
- Set host on requests from activator to trigger authconfig
- Temp Authorization header fix to workaround https://issues.redhat.com/browse/OSSM-4873
…ion and asserting it succeeded
… the fields propagated
- rename k8serrors to apierrs for consistency - Use controllerutil methods add and remove finalizer Signed-off-by: Wen Zhou <[email protected]>
* Activate extauth for grpc traffic * Set host on requests from activator to trigger authconfig * Temp Authorization header fix to workaround https://issues.redhat.com/browse/OSSM-4873
@aslakknutsen how can I test it? |
Not much to test beyond that they get installed. This depends on a few other PRs coming elsewhere |
You can always setup a echo service on port 8013 with label "component: predicator" and;
|
As for the linter errors, I will soon push cleanup to the target branch so we will see if there's anything left in your PR |
d39d17c
to
68a57c7
Compare
Closes, as it's been reworked in #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.