Email editor – fix sidebar header [MAILPOET-6371] #5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was fixed in @wordpress/interface but we were using the older version. The @wordpress/interface is not distributed standalone in WP Core so we bundle it. [MAILPOET-6371]
lysyjan
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Good job @costasovo with investigating this issue! Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that is when the new Gutenberg version is active.
The issue was already fixed upstream WordPress/gutenberg#64474
Because
@wordpress/interfaceis not distributed with WP Core, we bundle it. We were using an older version. This PR fixes the issue by updating to the latest version.Code review notes
N/A
QA notes
N/A
Linked PRs
N/A
Linked tickets
MAILPOET-6371
After-merge notes
N/A
Tasks
Preview
Preview in WordPress Playground
The latest successful build from
email-editor/fix-sidebar-headerwill be used. If none is available, the link won't work.