compat: do not rely on signal.h on PSP #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
|
The mpg123-devel mailing list has been notified of the existence of this pr. |
|
So this is only about the mere presence of the signal handling function? You are only building the libraries, right? Seems like splitting out this part of compat.c really makes sense. Also, the logic guarding use of that function doesn't match that of definition. That probably should be fixed, too. |
|
Yeah I'm only building the libraries. If a file has functions like sigaction in it you'll get linking errors, because we don't have those, despite Alternatively I could also set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pull request I made, makes it possible to build for the Playstation Portable (PSP), which can be found here: #17
This small change finishes the work needed to make libmpg123 work on the PSP. I tested it using SDL2_Mixer and it works flawlessly from what I can tell.