-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ollama: new port (v0.5.7) #27350
base: master
Are you sure you want to change the base?
ollama: new port (v0.5.7) #27350
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If you set |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So why not start with generating the port via EDIT: To be fair, Make doesn't add much complexity. Still, it baffles me why this isn't generated by |
Adding @amake for thoughts/comments |
I agree with this, which is why I use go2port on all the golang ports I maintain, even when the results needs manual tweaking on every update. But I have given up trying to get other people to do likewise. It's bad, but golang chose to have a module system that is hostile to our interests, and ultimately us choosing to have online-built ports is, I guess, better than not having the port at all. |
I definitely want to help you tackle this, via the |
That said, this isn't an indictment of the usefulness of And if I'm going to proceed the standard Go way, then I'll just use the bundled Makefile so that Go is executed in exactly the way the project intends to execute it. |
I'm reasonably certain that we can fix the issues, by updating the code to use the Go lib [for packages]. And that's something I plan to tackle soon, in collaboration with @amake. So if you aren't in a hurry to merge this, perhaps we can use this port as a test case? In terms of an ETA, I'm hoping to look at it over the next few days. |
Squashed continuation of @rdallman 's PR here: #25274