Skip to content

Commit

Permalink
update code and get all tests passing 🎉
Browse files Browse the repository at this point in the history
  • Loading branch information
trusktr committed Nov 8, 2023
1 parent 0b06079 commit 6829277
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 6 deletions.
2 changes: 1 addition & 1 deletion dist/decorators/reactive.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/decorators/reactive.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions dist/index.test.d.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
declare global {
function expect(...args: any[]): any;
}
export {};
//# sourceMappingURL=index.test.d.ts.map
2 changes: 1 addition & 1 deletion dist/index.test.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions dist/index.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.test.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"url": "git+ssh://[email protected]/lume/classy-solid.git"
},
"bugs": {
"url": "https://github.com/lume/variable/issues"
"url": "https://github.com/lume/classy-solid/issues"
},
"keywords": [
"solidhack",
Expand Down
2 changes: 1 addition & 1 deletion src/decorators/reactive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function reactive(...args: any[]): any {
// @prod-prune
if (!(hasOwnProperty.call(instance, prop) || hasOwnProperty.call(Class.prototype, prop))) {
throw new Error(
`Property "${prop.toString()}" not found on object. Did you forget to use the \`@reactive\` decorator on a class that has properties decorated with \`@signal\`?`,
`Property "${prop.toString()}" not found on instance of class decorated with \`@reactive\`. Did you forget to use the \`@reactive\` decorator on one of your classes that has a "${prop.toString()}" property decorated with \`@signal\`?`,
)
}

Expand Down
6 changes: 6 additions & 0 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ import {
component,
} from './index.js'

// TODO move type def to @lume/cli, map @types/jest's `expect` type into the
// global env.
declare global {
function expect(...args: any[]): any
}

describe('classy-solid', () => {
describe('createSignalObject()', () => {
it('has gettable and settable values via .get and .set methods', async () => {
Expand Down

0 comments on commit 6829277

Please sign in to comment.