Add server/client annotations to settingtypes.txt and use them #15756
+202
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the "Deal with client-side vs server-side vs both sides settings correctly" part of #15701
Hide server-side settings in the pause menu if playing on a remote server (because changing them wouldn't have an effect, you'd have to change them on the remote server)
Always hide world-creation settings in the pause menu (because changing them wouldn't have an effect, you'd have to create a new world)
To do
This PR is a Ready for Review.
How to test
For fun, you can set
shown_contexts.client = false
to see server-side settings only. This should work too as of f72ae78. Off-topic idea: It might be interesting to add a/serversettings
command for server admins in the future, based on the same settings menu code.