Add Settings to in-game menu, and rewrite it in C++ #14781
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds settings to the pause menu.
In the past, you need to quit the current game to change settings. This is tedious, especially when on servers where you need to re-enter your password. It's also frustrating as you can't fine-tune settings such as FOV.
To do this, the lua is slowly rewritten in C++. This will probably benefit my other PR #14763, so I am going to finish this first.
Also, we can probably remove the "Sound" subsection. We could also move all the "Controls" configuration to this settings menu (which also lets us tweak controls on the main menu.. 2 birds dead with 1 stone!)
Fixes #6722, #3165, #6922, etc etc etc
How to test
(Note: As of typing this, the main menu's settings button is still the lua one)