-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manual merge] VBO-related optimizations and improvements #14395
Conversation
23fd2c2
to
49a384f
Compare
I tried. Everything seems to still work. No performance gain, though. |
That's largely to be expected, unless you're stress-testing entity or item rendering (maybe). |
6110307
to
48d4a93
Compare
Consistently applying this setting requires some code work, because Irrlicht does not provide a global toggle. At the same time I don't see any reason for someone to disable this.
Looks good. |
@sfan5 The assert at |
Yep, noticed it. PR soon. |
goal:
applicability: dunno, but I had fun and learned stuff while working on the cloud code.
note for second commit:
We would need to wrap every call to
setHardwareMappingHint
(try ctrl+f) into an if that checks the setting and also cache that etc. All while there is essentially no reason to disable VBOs.(Irrlicht won't use them if they are not supported for some reason.)
How to merge
Keep all commits that start with upper-case letters
Squash others into one and name it
VBO-related optimizations and improvements (#14395)
To do
This PR is Ready for Review.
How to test
/time 19:00
)